Skip to content

coordinator: adds config v2 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluentcrafter merged 39 commits into from
Jun 6, 2025
Merged

coordinator: adds config v2 #853

fluentcrafter merged 39 commits into from
Jun 6, 2025

Conversation

@fluentcrafter
Copy link
Collaborator

@fluentcrafter fluentcrafter commented Apr 8, 2025 •
edited by julien-marchand
Loading

This PR implements issue(s) #922

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.18936% with 605 lines in your changes missing coverage. Please review.

Project coverage is 65.92%. Comparing base (62b422b) to head (62c8b30).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 283 Missing ⚠️
...a/coordinator/config/v2/toml/ConfigLoaderHelper.kt 50.64% 34 Missing and 4 partials ⚠️
...nea/coordinator/config/v2/toml/SignerConfigToml.kt 54.68% 11 Missing and 18 partials ⚠️
...kotlin/linea/coordinator/config/v2/SignerConfig.kt 40.00% 22 Missing and 2 partials ⚠️
...lin/linea/coordinator/config/v2/toml/ProverToml.kt 61.29% 22 Missing and 2 partials ⚠️
...ea/coordinator/config/v2/MessageAnchoringConfig.kt 57.14% 14 Missing and 7 partials ⚠️
...nator/config/v2/toml/MessageAnchoringConfigToml.kt 78.08% 7 Missing and 9 partials ⚠️
...kotlin/linea/coordinator/config/v2/ProverConfig.kt 0.00% 14 Missing ⚠️
...act/l2/Web3JL2MessageServiceSmartContractClient.kt 0.00% 14 Missing ⚠️
...ea/coordinator/config/v2/toml/decoders/Decoders.kt 55.55% 6 Missing and 6 partials ⚠️
... and 31 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #853      +/-   ##
============================================
- Coverage     66.59%   65.92%   -0.67%     
- Complexity     1135     1172      +37     
============================================
  Files           324      354      +30     
  Lines         12994    13494     +500     
  Branches       1356     1361       +5     
============================================
+ Hits           8653     8896     +243     
- Misses         3780     4033     +253     
- Partials        561      565       +4
Flag Coverage Δ
hardhat 98.51% <ø> (ø)
kotlin 63.47% <58.18%> (-0.62%) ⬇️
Files with missing lines Coverage Δ
...in/kotlin/linea/coordinator/config/v2/ApiConfig.kt 100.00% <100.00%> (ø)
.../linea/coordinator/config/v2/toml/ApiConfigToml.kt 100.00% <100.00%> (ø)
...n/linea/coordinator/config/v2/toml/DatabaseToml.kt 100.00% <100.00%> (ø)
...n/linea/coordinator/config/v2/toml/DefaultsToml.kt 100.00% <100.00%> (ø)
...nea/coordinator/config/v2/toml/StateManagerToml.kt 100.00% <100.00%> (ø)
...nator/config/v2/toml/Type2StateProofManagerToml.kt 100.00% <100.00%> (ø)
...sensys/zkevm/coordinator/app/CoordinatorAppMain.kt 0.00% <ø> (ø)
...n/net/consensys/zkevm/ethereum/ContractsManager.kt 61.53% <100.00%> (+0.75%) ⬆️
...n/src/main/kotlin/linea/kotlin/StringExtensions.kt 100.00% <100.00%> (ø)
...faces/src/main/kotlin/linea/ethapi/EthApiClient.kt 50.00% <ø> (ø)
... and 41 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e April 15, 2025 12:58 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter mentioned this pull request Apr 30, 2025
Closed
2 tasks
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from a302a6d to 80c512d Compare May 9, 2025 12:32
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 80c512d to 55171cf Compare May 9, 2025 12:56
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 55171cf to 8fab64a Compare May 13, 2025 07:39
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 8fab64a to 898dfcd Compare May 22, 2025 11:24
@fluentcrafter fluentcrafter changed the title coordinator: adds config v2 sample coordinator: adds config v2 Jun 4, 2025
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 55748b9 to 154d2e0 Compare June 4, 2025 19:51
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 4, 2025 22:37 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter marked this pull request as ready for review June 4, 2025 22:52
@fluentcrafter fluentcrafter requested review from Filter94 and jonesho June 4, 2025 22:52
jonesho
jonesho reviewed Jun 5, 2025
View reviewed changes
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 08:09 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 28dd45d to 1b96f32 Compare June 5, 2025 09:22
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 09:40 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 13:51 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 14:30 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 15:04 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 21:04 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter requested review from Filter94 and jonesho June 5, 2025 22:55
@jonesho jonesho had a problem deploying to docker-build-and-e2e June 6, 2025 06:33 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e June 6, 2025 07:48 — with GitHub Actions Error
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 6, 2025 09:07 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter requested a review from Filter94 June 6, 2025 10:14
@fluentcrafter fluentcrafter merged commit 0c7c736 into main Jun 6, 2025
33 checks passed
@fluentcrafter fluentcrafter deleted the coordinator-config-v2 branch June 6, 2025 10:15
AlexandreBelling pushed a commit that referenced this pull request Oct 28, 2025
@fluentcrafter
@Filter94 @jonesho @AlexandreBelling
coordinator: adds config v2 (#853)
dd5847c 
* coordinator: adds config v2 sample

* coordinator: update config V2

* coordinator: update config v2

* coordinator: update config v2

* coordinator: config v2 wip

* spotless fix

* coordinator: adds config v2 parsers

* coordinator: adds config v2 classes and parsing tests

* coordinator: adds config v2 classes and parsing tests

* remove end2end changes from staterecovery test trigger

* coordinator: config v2 - fix prover directory config

* coordinator: add getChaindId to EthApiClient.kt

* coordinator: improve EIP1559GasProvider validation

* coordinator: add createReadOnly to Web3JL2MessageServiceSmartContractClient

* coordinator: add validation to FeeHistoryFetcherImpl

* coordinator: add more configs to v2

* coordinator: extend Web3JFactory

* coordinator: addapt CoordinatorApp to new V2 configs

* coordinator: adapt local stack coordinator configs

* coordinator: log4j clients.l1 debug

* coordinator: revert attempt to use web3signer on CI ONly :(

* coordinator: fix test and configs

* coordinator: fix test and configs

* coordinator: fix traces node address

* coordinator: remove unnecessary file

* coordinator: hardcode tracesVersion to v2.1.0 to match prover regex

* Update config/coordinator/coordinator-config-v2.toml

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Fluent Crafter <[email protected]>

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Roman Vaseev <[email protected]>
Signed-off-by: Fluent Crafter <[email protected]>

* coordinator: default targetBlobsPerTransaction=7u

* coordinator: hardcode tracesVersion to 2.1.0 to match prover regex

* coordinator: fix agg configs

* coordinator: strict configs log warning when config is not used

* coordinator: add carved out config files

* coordinator: add opt-in to avoid annoying warning log

* feat: update Makefile for new coordinator config file and variable name

* localstack: remove coordinator forced platform

* coordinator: add missing config on gas-price-cap-calculation

* coordinator: remove old configs

---------

Signed-off-by: Fluent Crafter <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Roman Vaseev <[email protected]>
Co-authored-by: jonesho <[email protected]>
Co-authored-by: jonesho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Filter94 Filter94 Filter94 approved these changes

@jonesho jonesho jonesho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fluentcrafter @codecov-commenter @Filter94 @jonesho